Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[Enhancement] Introduce left and right float alignment options to latest posts block #8814
This PR closes #8777 which request the availability of left and right float alignment options in the Latest Posts block, making it consistent like the Archive, Latest Comments, and Categories blocks.
How has this been tested?
This PR has been tested by going through the following steps:
This was tested in WP 4.9.8, Gutenberg 3.5.0, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.
Types of changes
This PR just omits the
referenced this pull request
Aug 10, 2018
Looks like the left and right float alignments are working in both editor and front-end to me! Notably, however, the center alignment option is still applied by default for some reason. That bug is tracked in #7911; if you could fix that in this PR, that would be great, but this is already an improvement over
@nfmohit-wpmudev, I'm unable to get this to run at this point — probably needs a rebase. From a design perspective, the mockup you have above (adding those two standard alignment buttons to the block toolbar) is the right thing to do, so I'm going to remove the
@nfmohit-wpmudev @kjellr I forgot about this PR and made my own PR adding all alignment options to all widget blocks. But anyway, in case that PR is rejected or something, here is what you need to do to get this PR working:
You need to modify
@ZebulanStanphill Thank you for the heads up bud
Don't you think including the