New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to the WordPress installation if DOCKER_ENV=localwpdev #8818

Merged
merged 3 commits into from Aug 10, 2018

Conversation

Projects
None yet
4 participants
@notnownikki
Member

notnownikki commented Aug 10, 2018

Description

Adds a new docker-compose file that overrides volume settings so that WordPress can be accessed for theme or core dev.

How has this been tested?

CI should run as normal, DOCKER_ENV=localwpdev ./bin/setup-local-env.sh should expose WordPress

@notnownikki notnownikki requested review from tofumatt and pento Aug 10, 2018

@pento

pento approved these changes Aug 10, 2018

Nice work, @notnownikki! I ❤️ this approach, just left a couple of comments, but otherwise looks good! 🙂

wordpress:
volumes:
- ./wordpress:/var/www/html

This comment has been minimized.

@pento

pento Aug 10, 2018

Member

Does the -f work the same as docker-compose.override.yml? If it does, we should only need to configure the /var/www/html mount point, rather than duplicating all of them.

@pento

pento Aug 10, 2018

Member

Does the -f work the same as docker-compose.override.yml? If it does, we should only need to configure the /var/www/html mount point, rather than duplicating all of them.

This comment has been minimized.

@notnownikki

notnownikki Aug 10, 2018

Member

You're absolutely right, have corrected this :)

@notnownikki

notnownikki Aug 10, 2018

Member

You're absolutely right, have corrected this :)

Show outdated Hide outdated docker-compose-localdev.yml

notnownikki added some commits Aug 10, 2018

@notnownikki notnownikki merged commit 29ccdcb into master Aug 10, 2018

2 checks passed

codecov/project 51.08% remains the same compared to dd78fd2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tofumatt tofumatt deleted the update/expose-wordpress-on-localdev branch Aug 10, 2018

@mtias mtias added this to the 3.6 milestone Aug 16, 2018

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 21, 2018

Contributor

THIS IS SO COOL!

Contributor

jasmussen commented Aug 21, 2018

THIS IS SO COOL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment