Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Block: Avoid scrollbars when shown full-width #8820

Merged
merged 1 commit into from Aug 10, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Copy link
Contributor

youknowriad commented Aug 10, 2018

It looks like figures have margin by default which causes scrollbars if their content is 100% in full-width. This could be solved in several ways, so let me know what you think.

closes #8717

Testing instructions

  • Add an audio block
  • Make it full width
  • No scrollbars.

@youknowriad youknowriad added the Blocks label Aug 10, 2018

@youknowriad youknowriad self-assigned this Aug 10, 2018

@youknowriad youknowriad requested a review from jasmussen Aug 10, 2018

@jasmussen
Copy link
Contributor

jasmussen left a comment

Yes! Ship it!

Thank you for being mindful of horizontal scrollbars.

@youknowriad youknowriad merged commit 6627001 into master Aug 10, 2018

2 checks passed

codecov/project 51.08% remains the same compared to dd78fd2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/audio-block-scroll branch Aug 10, 2018

@mtias mtias added this to the 3.6 milestone Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.