New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color palette: clear the floating link that clears color #8874

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
2 participants
@eliorivero
Contributor

eliorivero commented Aug 11, 2018

Description

This PR seeks to solve a layout issue with the color palette: the last element in the palette is the Clear link that resets the color, and it's floated, thus causing some collapsing in the container since it's not cleared. This PR solves the layout issue and the dimensions of the container are correctly rendered. With this clear, the bottom margin is no longer necessary.

How has this been tested?

Can be inspected using Dev Tools

Screenshots

Before

captura de pantalla 2018-08-11 a la s 01 53 48

After

captura de pantalla 2018-08-11 a la s 01 53 23

Note that the overflowing color dialog is not affected by this change 馃憤
captura de pantalla 2018-08-11 a la s 13 45 45

Types of changes

Sets the display for the color swatches and Clear link container to inline-block to properly clear the float without affecting its inner elements.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@eliorivero eliorivero changed the title from Clear the float from the link that clears color in color palette to Color palette: clear the floating link that clears color Aug 11, 2018

Clear the float from the link that clears color in color palette so i鈥
鈥s dimensions are correctly rendered. With this clear, the bottom margin is no longer necessary.
@tofumatt

Works for me!

@tofumatt tofumatt merged commit 5800ed3 into WordPress:master Aug 23, 2018

2 checks passed

codecov/project 50.84% remains the same compared to 0c36e7f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tofumatt tofumatt added this to the 3.7 milestone Aug 23, 2018

@eliorivero

This comment has been minimized.

Show comment
Hide comment
@eliorivero

eliorivero Aug 24, 2018

Contributor

Thanks @tofumatt for the review, approval, and merge!

Contributor

eliorivero commented Aug 24, 2018

Thanks @tofumatt for the review, approval, and merge!

@eliorivero eliorivero deleted the eliorivero:update/clear-color-clear branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment