New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Module: Correctly handle per_page=-1 in the queried data state #8908

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Aug 13, 2018

closes #8848

This PR fixes an issue where we were requestion all the data (per_page=-1) but receiving only 10 in the selector.

There are actually two bug fixes here:

  • We were expecting the query to contain a perPage argument while it's in reality per_page
  • The "unlimited" pagination flag was not being handled properly in the selector and we were always returning 10 elements.

Testing instructions

  • Create more than 10 pages
  • Check that the page parent selector shows all the pages properly.

@youknowriad youknowriad added this to the 3.6 milestone Aug 13, 2018

@youknowriad youknowriad self-assigned this Aug 13, 2018

@danielbachhuber

I can confirm more than 10 pages load in the page selector:

image

@youknowriad youknowriad merged commit 4c441d2 into master Aug 13, 2018

2 checks passed

codecov/project 50.08% (+<.01%) compared to e1811b2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/paginated-queries branch Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment