Fix crashed block height and inserted order #8926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #8868 a crashed block has a minimum height that is too small causing the block beneath to overlap:
Also described in #8868 the inline block inserter appears beneath a crashed block:
How has this been tested?
Manually verify that after applying this PR a crashed block appears as so, with the next block not overlapped, and the block inserter not being hidden:
Note: to create a crashed block enter this in developer tools console and then add the
Mr Crashy
block:wp.blocks.registerBlockType( 'myplugin/mr-crashy', { title: 'Mr. Crashy', category: 'common', icon: 'warning', edit() { throw new Error(); }, save() { return ''; } } );
Types of changes
Bug fix
Checklist: