New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy: use sentence case for all texts in tooltips #8927

Merged
merged 3 commits into from Aug 22, 2018

Conversation

Projects
None yet
4 participants
@eliorivero
Contributor

eliorivero commented Aug 13, 2018

Fixes #8888

Description

This PR seeks to unify the title style in the copy used in all black tooltips by using sentence case as pointed in #8888 (comment)

How has this been tested?

Checking each tooltip copy in the UI.

Screenshots

captura de pantalla 2018-08-13 a la s 12 20 10

captura de pantalla 2018-08-13 a la s 12 20 24

captura de pantalla 2018-08-14 a la s 15 17 07

captura de pantalla 2018-08-13 a la s 12 21 03

The last one shows only one color but all color names have been updated.

Types of changes

Updates the text for tooltips.
Removes 'Publish' from 'Close Publish panel'

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
@michelleweber

This comment has been minimized.

Show comment
Hide comment
@michelleweber

michelleweber Aug 13, 2018

Close Publish panel looks a a little funny because Publish is the proper name -- could we omit the "Publish," or does that introduce too much ambiguity?

Otherwise, looks good.

michelleweber commented Aug 13, 2018

Close Publish panel looks a a little funny because Publish is the proper name -- could we omit the "Publish," or does that introduce too much ambiguity?

Otherwise, looks good.

@eliorivero

This comment has been minimized.

Show comment
Hide comment
@eliorivero

eliorivero Aug 14, 2018

Contributor

Good call @michelleweber. It does make sense since the keyboard shortcut dialog only says "Close dialog"

captura de pantalla 2018-08-14 a la s 15 16 54

So I've removed Publish and updated its screenshot in the PR description.

Contributor

eliorivero commented Aug 14, 2018

Good call @michelleweber. It does make sense since the keyboard shortcut dialog only says "Close dialog"

captura de pantalla 2018-08-14 a la s 15 16 54

So I've removed Publish and updated its screenshot in the PR description.

@talldan

talldan approved these changes Aug 22, 2018 edited

Looks good to me. Thanks for your contribution @eliorivero. 😄

@talldan talldan added this to the 3.7 milestone Aug 22, 2018

@talldan talldan merged commit 6b2e673 into WordPress:master Aug 22, 2018

2 checks passed

codecov/project 50.92% remains the same compared to bc4d7a2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eliorivero eliorivero deleted the eliorivero:update/tooltip-text-sentence-case branch Aug 22, 2018

@eliorivero

This comment has been minimized.

Show comment
Hide comment
@eliorivero

eliorivero Aug 22, 2018

Contributor

Thanks for the approval and merge @talldan 👍

Contributor

eliorivero commented Aug 22, 2018

Thanks for the approval and merge @talldan 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment