New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the workaround for intermittent multiple-tab preview test failure #8928

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
2 participants
@notnownikki
Member

notnownikki commented Aug 13, 2018

Description

The workaround needed for the preview test to complete reliably without opening multiple preview tabs can be removed, this seems to pass reliably in the environments it was failing in before.

How has this been tested?

Run the e2e tests over and over on a machine that's under load.

@aduth

aduth approved these changes Aug 13, 2018

Looks good 👍

@notnownikki notnownikki merged commit a5b6126 into master Aug 13, 2018

2 checks passed

codecov/project 50.59% remains the same compared to eeb298e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notnownikki notnownikki deleted the update/remove-multiple-tab-workaround-for-preview-test branch Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment