New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow publishing pages #9082

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Projects
None yet
3 participants
@nosolosw
Member

nosolosw commented Aug 17, 2018

How to reproduce the bug:

  • Add a new page
  • Try to publish it

Expected behavior is that the pre-publish panel would be opened. Instead, I've got:

error-publish-page

@nosolosw nosolosw requested a review from tofumatt Aug 17, 2018

@nosolosw nosolosw self-assigned this Aug 17, 2018

@nosolosw nosolosw added the [Type] Bug label Aug 17, 2018

@tofumatt

We should get this in ASAP as a patch, but I'm shocked we don't have an end-to-end test that would catch this. We definitely should add one. 😓

@mcsf

mcsf approved these changes Aug 17, 2018

@nosolosw nosolosw merged commit a6c41df into master Aug 17, 2018

2 checks passed

codecov/project 50.84% (-0.01%) compared to 48c6a5e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nosolosw nosolosw deleted the fix/publish-pages branch Aug 17, 2018

@nosolosw nosolosw referenced this pull request Aug 17, 2018

Merged

PrePublishPanel: suggest tags and postformat #8235

9 of 9 tasks complete

@mcsf mcsf added this to the 3.6 milestone Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment