New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wide toolbar regression. #9083

Merged
merged 3 commits into from Aug 17, 2018

Conversation

Projects
None yet
5 participants
@jasmussen
Contributor

jasmussen commented Aug 17, 2018

This PR fixes a regression introduced in https://github.com/WordPress/gutenberg/pull/8840/files#diff-1f76ee5adc19638316fea06f655caa9aR2, which caused the block toolbar to not be centered on wide and fullwide blocks.

In master:

screen shot 2018-08-17 at 13 35 39

After this PR:

screen shot 2018-08-17 at 13 34 56

Fix wide toolbar regression.
This PR fixes a regression introduced in https://github.com/WordPress/gutenberg/pull/8840/files#diff-1f76ee5adc19638316fea06f655caa9aR2, which caused the block toolbar to not be centered on wide and fullwide blocks.

@jasmussen jasmussen self-assigned this Aug 17, 2018

@jasmussen jasmussen requested a review from youknowriad Aug 17, 2018

@mcsf mcsf added this to the 3.7 milestone Aug 17, 2018

@chrisvanpatten

This comment has been minimized.

Show comment
Hide comment
@chrisvanpatten

chrisvanpatten Aug 17, 2018

Contributor

Is there any way the concerns in #7374 could be addressed here, or is that too far off?

Contributor

chrisvanpatten commented Aug 17, 2018

Is there any way the concerns in #7374 could be addressed here, or is that too far off?

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Aug 17, 2018

Contributor

screen shot 2018-08-17 at 13 09 42

See the whitespace under the block toolbar. The flex display fixes that. (that's firefox)

Contributor

youknowriad commented Aug 17, 2018

screen shot 2018-08-17 at 13 09 42

See the whitespace under the block toolbar. The flex display fixes that. (that's firefox)

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 17, 2018

Contributor

Is there any way the concerns in #7374 could be addressed here, or is that too far off?

I assigned myself that one, but would like to look at that separately.

Contributor

jasmussen commented Aug 17, 2018

Is there any way the concerns in #7374 could be addressed here, or is that too far off?

I assigned myself that one, but would like to look at that separately.

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 17, 2018

Contributor

Pushed a fix so the toolbar is only inline-flex on wide and fullwide blocks, and only beyond the mobile breakpoint. Thoughts?

Contributor

jasmussen commented Aug 17, 2018

Pushed a fix so the toolbar is only inline-flex on wide and fullwide blocks, and only beyond the mobile breakpoint. Thoughts?

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Aug 17, 2018

Contributor

@jasmussen Testing :)

Contributor

youknowriad commented Aug 17, 2018

@jasmussen Testing :)

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Aug 17, 2018

Contributor

screen shot 2018-08-17 at 13 22 51

Maybe it's not the right breakpoint, but I'm seeing the issue on wide aligned images at some point :)

Contributor

youknowriad commented Aug 17, 2018

screen shot 2018-08-17 at 13 22 51

Maybe it's not the right breakpoint, but I'm seeing the issue on wide aligned images at some point :)

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 17, 2018

Contributor

Correct, that was the wrong breakpoint. now it should be good.

Contributor

jasmussen commented Aug 17, 2018

Correct, that was the wrong breakpoint. now it should be good.

@youknowriad

Thanks, LGTM 👍

@mtias mtias merged commit 2318842 into master Aug 17, 2018

2 checks passed

codecov/project 50.84% (-0.01%) compared to 48c6a5e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtias mtias deleted the fix/wide-toolbar-regression branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment