New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for publishing a page #9090

Merged
merged 2 commits into from Aug 17, 2018

Conversation

Projects
None yet
3 participants
@nosolosw
Member

nosolosw commented Aug 17, 2018

Fix #9087.

@nosolosw nosolosw requested a review from tofumatt Aug 17, 2018

@nosolosw nosolosw self-assigned this Aug 17, 2018

@tofumatt

I made some documentation tweaks but looks good. 👍 We might want to check that other behaviour for pages are covered as well, but this is a great start!

// Start editing again.
await page.type( '.editor-post-title__input', ' (Updated)' );
// The post-publishing panel is not visible anymore.

This comment has been minimized.

@tofumatt

tofumatt Aug 17, 2018

Member

This doesn't really feel like a test related to the publishing of a post in the first place, but I get it was like that when you got here 😄

@tofumatt

tofumatt Aug 17, 2018

Member

This doesn't really feel like a test related to the publishing of a post in the first place, but I get it was like that when you got here 😄

@nosolosw nosolosw merged commit 0c36e7f into master Aug 17, 2018

2 checks passed

codecov/project 50.84% remains the same compared to 2318842
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nosolosw nosolosw deleted the add/e2e-test-publish-page branch Aug 17, 2018

@@ -7,22 +7,45 @@ import {
} from '../support/utils';
describe( 'Publishing', () => {
beforeEach( async () => {
await newPost();
describe( 'a post', () => {

This comment has been minimized.

@aduth

aduth Aug 17, 2018

Member

FWIW we could avoid code duplication by iterating types if all other logic is basically the same:

[ 'post', 'page' ].forEach( ( postType ) => {
	describe( postType, () => {
		beforeEach( async () => {
			await newPost( postType );
		} );

		// ...
	} );
} );
@aduth

aduth Aug 17, 2018

Member

FWIW we could avoid code duplication by iterating types if all other logic is basically the same:

[ 'post', 'page' ].forEach( ( postType ) => {
	describe( postType, () => {
		beforeEach( async () => {
			await newPost( postType );
		} );

		// ...
	} );
} );

@nosolosw nosolosw referenced this pull request Sep 17, 2018

Merged

Add option to skip PublishSidebar on publishing #9760

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment