New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Fix typo for removing excerpt block stripping #9093

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Aug 17, 2018

Fixes #9084
Regression introduced in #8984

This pull request seeks to resolve an issue where a filter which was responsible for stripping dynamic blocks from excerpts was never properly removed. The original implementation appears to have intended to temporarily add a filter for excerpts, but due to what I'm attributing to be a typo, it was never removed because it had specified the incorrect function name. Prior to these changes, the strip_dynamic_blocks_remove_filter was an unused function.

Testing instructions:

Repeat steps to reproduce from #9084, verifying that Latest Posts appears as expected with the Yoast plugin activated.

@aduth aduth added the Framework label Aug 17, 2018

@aduth aduth requested review from mcsf, youknowriad, pento and obenland Aug 17, 2018

@mcsf

mcsf approved these changes Aug 17, 2018

@aduth aduth merged commit b978aa8 into master Aug 17, 2018

2 checks passed

codecov/project 50.84% remains the same compared to 0c36e7f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the fix/strip-dynamic-blocks-filter branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment