New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 flexbox fix for keyboard shortcuts help #9157

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
2 participants
@talldan
Contributor

talldan commented Aug 20, 2018

Description

I must have made a mistake when I originally merged the keyboard shortcuts help modal, as there are IE11 flex issues 🤦‍♂️. This branch fixes things.

  • Moves the flex:1 to the correct flex item (the description)
  • Removes no longer needed text-align
  • Adds flex-basis: 1 as an IE11 fix to stop the description collapsing.

How has this been tested?

  • Tested the changes on IE11, edge, chrome, firefox, safari and opera.

Screenshots

Here's how it looks now in IE:
keyboardshortcuts-ie11

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@talldan talldan requested a review from jasmussen Aug 20, 2018

@talldan talldan self-assigned this Aug 20, 2018

@talldan talldan changed the title from IE11 fix for keyboard shortcuts help to IE11 flexbox fix for keyboard shortcuts help Aug 20, 2018

@jorgefilipecosta

I tested the changes in IE11 and some other browsers and the results seem good 👍

@talldan talldan added this to the 3.7 milestone Aug 21, 2018

@talldan talldan merged commit 87780df into master Aug 21, 2018

2 checks passed

codecov/project 50.83% remains the same compared to e8f6bb0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@talldan talldan deleted the fix/keyboard-shortcut-modal-on-ie11 branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment