New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eslint issues found in block-serialization-spec-parser packages #9166

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@gziolo
Member

gziolo commented Aug 20, 2018

Description

Fixes issue raised by @aduth in the comment:

Why do we ignore the entire package? Could we just ignore the singular file(s) which are generated? The test file, for example, includes a number of legitimate code style violations.

It turned out that using toMatchInlineSnapshot doesn't work quite well for use because it uses prettier behind the scenes. We can't really use it with the current setup unless we adopt calypso-prettier.

This PR ensures that only generated file is ignored by lint checks and updates existing test suite code to pass Eslint checks.

How has this been tested?

npm test

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added the Code Quality label Aug 20, 2018

@gziolo gziolo added this to the 3.7 milestone Aug 20, 2018

@gziolo gziolo self-assigned this Aug 20, 2018

@gziolo gziolo requested a review from aduth Aug 20, 2018

@gziolo gziolo referenced this pull request Aug 20, 2018

Merged

Packages: Create new `spec-parser` package #7664

4 of 4 tasks complete
@aduth

aduth approved these changes Aug 20, 2018

👍 Thanks.

@gziolo gziolo merged commit d27c73e into master Aug 20, 2018

2 checks passed

codecov/project 50.83% remains the same compared to f90b2d6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/block-spec-parser-eslint branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment