Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update Facebook icon SVG #9178
#8916 added some custom block icons, including a facebook icon. For some reason, the facebook icon is missing most of its curved lines, and its proportions are incorrect. This PR replaces it with a new SVG.
Current icon on the left, new icon on the right:
Before, in context:
After, in context:
I really kind of hate that we are becoming the maintainers of 3rd party icons. IMO that is their domain, and we shouldn't have to maintain it.
However given that we have an Embed block for it, we might as well not let the user experience suffer. So ship it, and nice work!
Aug 21, 2018
@kjellr Congrats on the first merge :) Yes, please assign whichever milestone is appropriate.
There are some more details generally in this document: https://github.com/WordPress/gutenberg/blob/master/docs/reference/repository-management.md#merging-pull-requests If you find the document could be improved in some way, feel free to open an issue with the questions you have, or pull request with suggested changes.