New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only request the embed preview if we have a URL #9193

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
4 participants
@notnownikki
Member

notnownikki commented Aug 21, 2018

Description

We were requesting a preview for URLs even if the URL hadn't been entered yet, so creating a new embed block resulted in an unneeded API call. This stops that.

How has this been tested?

Create a new embed block, check there are no API calls sent to the embed endpoints.

Types of changes

Bug fix

@notnownikki notnownikki changed the title from Only request the preview if we have a URL to Only request the embed preview if we have a URL Aug 21, 2018

@tofumatt

Tested locally and works for me! 👍

@notnownikki notnownikki merged commit 6d1d284 into master Aug 21, 2018

2 checks passed

codecov/project 50.87% remains the same compared to e2f3120
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notnownikki notnownikki deleted the fix/only-request-preview-if-have-url branch Aug 21, 2018

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Aug 22, 2018

Member

@notnownikki Can we make sure merged pull requests are assigned to milestones, please?

Member

danielbachhuber commented Aug 22, 2018

@notnownikki Can we make sure merged pull requests are assigned to milestones, please?

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Aug 22, 2018

Member

We really need a bot to do that, it's so easy to forget 😢

Member

tofumatt commented Aug 22, 2018

We really need a bot to do that, it's so easy to forget 😢

@notnownikki

This comment has been minimized.

Show comment
Hide comment
@notnownikki

notnownikki Aug 22, 2018

Member

Sorry, I didn't realise that was a thing we were doing with every PR now :(

Member

notnownikki commented Aug 22, 2018

Sorry, I didn't realise that was a thing we were doing with every PR now :(

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Aug 22, 2018

Member

Yeah, I don't even think it's documented. I'm going to see if I can whip up a bot that handles it now.

Member

tofumatt commented Aug 22, 2018

Yeah, I don't even think it's documented. I'm going to see if I can whip up a bot that handles it now.

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber
Member

danielbachhuber commented Aug 22, 2018

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Aug 22, 2018

Member

Oops, so it is documented. My bad also! 😓

Member

tofumatt commented Aug 22, 2018

Oops, so it is documented. My bad also! 😓

@mtias mtias added this to the 3.7 milestone Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment