New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double quotes in all NUX tips #9206

Merged
merged 4 commits into from Aug 21, 2018

Conversation

Projects
None yet
3 participants
@ZebulanStanphill
Contributor

ZebulanStanphill commented Aug 21, 2018

Description

Fixes #9205. Changes all NUX tips to consistently use double quotes rather than single quotes.

馃帀馃巿First Gutenberg PR hype!馃巿馃帀

ZebulanStanphill added some commits Aug 21, 2018

@ZebulanStanphill

This comment has been minimized.

Show comment
Hide comment
@ZebulanStanphill

ZebulanStanphill Aug 21, 2018

Contributor

Test failure is valid; I did not realize the text of the tips was duplicated in the tests and has to be changed there as well. Will fix.

Contributor

ZebulanStanphill commented Aug 21, 2018

Test failure is valid; I did not realize the text of the tips was duplicated in the tests and has to be changed there as well. Will fix.

@tofumatt

Those single-quotes were bugging me, thanks for filing the issue and for opening the PR! Nice! 馃憤

@tofumatt tofumatt merged commit 45f65dd into WordPress:master Aug 21, 2018

2 checks passed

codecov/project 50.89% remains the same compared to ba5dc99
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ZebulanStanphill ZebulanStanphill deleted the ZebulanStanphill:fix/9205-nux-inconsistent-quotes branch Aug 21, 2018

@ZebulanStanphill

This comment has been minimized.

Show comment
Hide comment
@ZebulanStanphill

ZebulanStanphill Aug 21, 2018

Contributor

馃巿馃槃馃帀

Contributor

ZebulanStanphill commented Aug 21, 2018

馃巿馃槃馃帀

@chrisvanpatten

This comment has been minimized.

Show comment
Hide comment
@chrisvanpatten
Contributor

chrisvanpatten commented Aug 21, 2018

giphy

@chrisvanpatten chrisvanpatten added this to the 3.7 milestone Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment