New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention of Material Design icons to the design docs. #9240

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
2 participants
@kjellr
Contributor

kjellr commented Aug 22, 2018

As per the update in #8916, our core blocks now use Material Design icons. This PR updates our design doc about block design to reflect that.

Old:

Blocks should have an identifying icon, ideally using a single color. Try to avoid using the same icon used by an existing block. Look to Dashicons for style inspiration.

New:

Blocks should have an identifying icon, ideally using a single color. Try to avoid using the same icon used by an existing block. The core block icons are based on Material Design Icons. Look to that icon set, or to Dashicons for style inspiration.

Add mention of Material Design icons to the design docs.
As per the update in #8916, our core blocks now use Material Design icons. This PR updates our design doc about block design to reflect that.

@kjellr kjellr self-assigned this Aug 22, 2018

@kjellr kjellr requested a review from karmatosed Aug 22, 2018

@karmatosed

Thanks for adding this ⭐️

@karmatosed karmatosed merged commit 0cae578 into master Aug 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kjellr kjellr added this to the 3.7 milestone Aug 24, 2018

@kjellr kjellr deleted the update/design-docs-iconset branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment