New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native Implement Basic text Toolbar actions #9267

Merged
merged 7 commits into from Aug 24, 2018

Conversation

Projects
None yet
3 participants
@SergioEstevao
Contributor

SergioEstevao commented Aug 23, 2018

Description

Refs: wordpress-mobile/gutenberg-mobile#128

This PR implements the connection of the toolbar with the richtext component in React Native.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

SergioEstevao added some commits Aug 22, 2018

@SergioEstevao SergioEstevao requested a review from daniloercoli Aug 23, 2018

@@ -21,12 +21,20 @@ import { children } from '@wordpress/blocks';
import FormatToolbar from './format-toolbar';
import { FORMATTING_CONTROLS } from './formatting-controls';
export function getFormatValue( formatName ) {

This comment has been minimized.

@daniloercoli

daniloercoli Aug 23, 2018

Contributor

@gziolo I wonder why we need to export this function here. Can 't it be moved in RichText component since it's only used there?

@daniloercoli

daniloercoli Aug 23, 2018

Contributor

@gziolo I wonder why we need to export this function here. Can 't it be moved in RichText component since it's only used there?

This comment has been minimized.

@gziolo

gziolo Aug 23, 2018

Member

I think it is exported only to be used in tests

@gziolo

gziolo Aug 23, 2018

Member

I think it is exported only to be used in tests

SergioEstevao and others added some commits Aug 23, 2018

@SergioEstevao SergioEstevao requested a review from gziolo Aug 23, 2018

@daniloercoli

Looks good Sergio!
There are some problems on Android but I think those are on react-native-aztec only. We will get it sorted in another PR.

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Aug 24, 2018

Member

Looks good, let's iterate on RichText in future PRs to find a common API for both Aztec and TinyMCE - the more code you add - the easier it's going to be to reason about those two implementations.

Member

gziolo commented Aug 24, 2018

Looks good, let's iterate on RichText in future PRs to find a common API for both Aztec and TinyMCE - the more code you add - the easier it's going to be to reason about those two implementations.

@gziolo

gziolo approved these changes Aug 24, 2018

@gziolo gziolo merged commit 7f0e824 into master Aug 24, 2018

2 checks passed

codecov/project 50.64% (-0.05%) compared to e959064
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the rnmobile/toolbar_actions branch Aug 24, 2018

@gziolo gziolo added this to the 3.7 milestone Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment