New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Allow disabling Google Fonts URL by translators. #9274

Merged
merged 1 commit into from Aug 26, 2018

Conversation

Projects
None yet
3 participants
@dimadin
Contributor

dimadin commented Aug 23, 2018

Description

It is standard practice by both WP core and default themes (as well as other well coded themes) to allow translators to disable Google Fonts. This PR brings that to Gutenberg.

@tofumatt tofumatt requested a review from WordPress/gutenberg-core Aug 23, 2018

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Aug 23, 2018

Member

It is standard practice by both WP core and default themes

Do you have a link to more information about this practice?

Member

aduth commented Aug 23, 2018

It is standard practice by both WP core and default themes

Do you have a link to more information about this practice?

@aduth aduth added the i18n label Aug 23, 2018

@gziolo gziolo requested a review from pento Aug 25, 2018

@dimadin

This comment has been minimized.

Show comment
Hide comment
@dimadin

dimadin Aug 25, 2018

Contributor

These are links to examples in WordPress code:

Here are relevant WP tickets:

Contributor

dimadin commented Aug 25, 2018

These are links to examples in WordPress code:

Here are relevant WP tickets:

@pento pento added this to the 3.7 milestone Aug 26, 2018

@pento

pento approved these changes Aug 26, 2018

👍🏻

@pento pento merged commit c345f59 into WordPress:master Aug 26, 2018

2 checks passed

codecov/project 50.69% remains the same compared to e959064
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Aug 27, 2018

Member

Thanks for the links @dimadin . It seems a non-obvious best practice that could probably do for inclusion in a handbook or the i18n guidelines.

Member

aduth commented Aug 27, 2018

Thanks for the links @dimadin . It seems a non-obvious best practice that could probably do for inclusion in a handbook or the i18n guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment