New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with missing SVG roles and attrs #9299

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Aug 24, 2018

This fixes #9269.

It adds back to the SVGs role="img" aria-hidden="true" focusable="false" properties that went missing as part of the block library iteration.

Fix regression with missing SVG roles and attrs
This fixes #9269.

It adds back to the SVGs `role="img" aria-hidden="true" focusable="false"` properties that went missing as part of the block library iteration.

@jasmussen jasmussen added this to the 3.7 milestone Aug 24, 2018

@jasmussen jasmussen self-assigned this Aug 24, 2018

@jasmussen jasmussen requested review from afercia and WordPress/gutenberg-core Aug 24, 2018

@tofumatt

So this fixes the issue for now, but as mentioned in
#9269 (comment) we should really have a component that blocks (our own and third-party ones) can use to create SVG icons that include these attributes. I've filed #9372 for that.

@jasmussen jasmussen merged commit 43e701a into master Aug 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/svgs branch Aug 27, 2018

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 27, 2018

Contributor

Thank you!

Contributor

jasmussen commented Aug 27, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment