New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "blockquote" as a keyword for the Quote block #9320

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
4 participants
@ZebulanStanphill
Contributor

ZebulanStanphill commented Aug 24, 2018

Description

Adds "blockquote" as a keyword for the quote block. I mean, it makes sense, right?

@ZebulanStanphill

This comment has been minimized.

Show comment
Hide comment
@ZebulanStanphill

ZebulanStanphill Aug 24, 2018

Contributor

Actually, I just realized that perhaps I should have called this branch "update/..." instead of "add/...". Is that an issue or is it fine?

Contributor

ZebulanStanphill commented Aug 24, 2018

Actually, I just realized that perhaps I should have called this branch "update/..." instead of "add/...". Is that an issue or is it fine?

@chrisvanpatten

This comment has been minimized.

Show comment
Hide comment
@chrisvanpatten

chrisvanpatten Aug 24, 2018

Contributor

@ZebulanStanphill I think it's okay!

Contributor

chrisvanpatten commented Aug 24, 2018

@ZebulanStanphill I think it's okay!

@tofumatt

Coolio, thanks!

@tofumatt tofumatt merged commit f62dbff into WordPress:master Aug 28, 2018

2 checks passed

codecov/project 50.6% remains the same compared to c28bc57
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tofumatt tofumatt added this to the 3.7 milestone Aug 28, 2018

@ZebulanStanphill ZebulanStanphill deleted the ZebulanStanphill:add/quote-block-blockquote-keyword branch Aug 28, 2018

@@ -49,6 +49,7 @@ export const settings = {
description: __( 'Maybe someone else said it better -- add some quoted text.' ),
icon: <svg viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><path fill="none" d="M0 0h24v24H0V0z" /><g><path d="M19 18h-6l2-4h-2V6h8v7l-2 5zm-2-2l2-3V8h-4v4h4l-2 4zm-8 2H3l2-4H3V6h8v7l-2 5zm-2-2l2-3V8H5v4h4l-2 4z" /></g></svg>,
category: 'common',
keywords: [ __( 'blockquote' ) ],

This comment has been minimized.

@mtias

mtias Aug 30, 2018

Contributor

@ZebulanStanphill This probably shouldn't be translatable?

@mtias

mtias Aug 30, 2018

Contributor

@ZebulanStanphill This probably shouldn't be translatable?

This comment has been minimized.

@tofumatt

tofumatt Aug 30, 2018

Member

Oh, why not? Wouldn’t translating it improve autocomplete in other locales?

@tofumatt

tofumatt Aug 30, 2018

Member

Oh, why not? Wouldn’t translating it improve autocomplete in other locales?

This comment has been minimized.

@mtias

mtias Aug 30, 2018

Contributor

I think the point is to match the HTML element here, with translations it'd mean that it can't be discovered by using "blockquote". Specially given there's no translation context, I'd imagine in Spanish this would be translated as "cita".

@mtias

mtias Aug 30, 2018

Contributor

I think the point is to match the HTML element here, with translations it'd mean that it can't be discovered by using "blockquote". Specially given there's no translation context, I'd imagine in Spanish this would be translated as "cita".

This comment has been minimized.

@ZebulanStanphill

ZebulanStanphill Aug 30, 2018

Contributor

I just made this translatable because keywords for other blocks were translatable, e.g. "movie" for the Video block. I also thought blockquote was a term that was used outside of the context of HTML for any quote shown in a container to make it stand out from the rest of the content. Am I mistaken on that?

@ZebulanStanphill

ZebulanStanphill Aug 30, 2018

Contributor

I just made this translatable because keywords for other blocks were translatable, e.g. "movie" for the Video block. I also thought blockquote was a term that was used outside of the context of HTML for any quote shown in a container to make it stand out from the rest of the content. Am I mistaken on that?

This comment has been minimized.

@chrisvanpatten

chrisvanpatten Aug 31, 2018

Contributor

This might be overkill but is there a world where it might make sense to have translatable and non-translatable versions? Makes sense to keep it for the HTML element name, but I think it’s also fair that it’s a general non-technical term as well.

@chrisvanpatten

chrisvanpatten Aug 31, 2018

Contributor

This might be overkill but is there a world where it might make sense to have translatable and non-translatable versions? Makes sense to keep it for the HTML element name, but I think it’s also fair that it’s a general non-technical term as well.

This comment has been minimized.

@mtias

mtias Aug 31, 2018

Contributor

It's more of a general question, for sure. We don't translate hr for separator, but we do translate separator. This one is a bit blurry.

@mtias

mtias Aug 31, 2018

Contributor

It's more of a general question, for sure. We don't translate hr for separator, but we do translate separator. This one is a bit blurry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment