New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video block: Add poster image #9335

Merged
merged 6 commits into from Aug 30, 2018

Conversation

Projects
None yet
5 participants
@Soean
Member

Soean commented Aug 24, 2018

Description

This PR adds the ability to add a poster image to the video block.

Fixes #4837

Screenshots

No poster selected
bildschirmfoto 2018-08-24 um 22 32 41

Poster selected
bildschirmfoto 2018-08-24 um 22 32 29

Workflow
video-poster

@gziolo gziolo added this to In Progress in API freeze via automation Aug 25, 2018

@gziolo gziolo added this to the 3.7 milestone Aug 25, 2018

@gziolo gziolo requested review from SergioEstevao and gziolo Aug 25, 2018

@gziolo gziolo requested a review from jasmussen Aug 28, 2018

@gziolo gziolo removed this from In Progress in API freeze Aug 28, 2018

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 28, 2018

Contributor

This is pretty cool.

Seeing as this is not part of this PR, separately we should consider adding contextual help to the switches. Their effect is boolean and instant so it's okay to use switches, but we should have some help text below.

Contributor

jasmussen commented Aug 28, 2018

This is pretty cool.

Seeing as this is not part of this PR, separately we should consider adding contextual help to the switches. Their effect is boolean and instant so it's okay to use switches, but we should have some help text below.

@SergioEstevao

I will leave the code review for the experts, but in terms of the output/input HTML it's what we are expecting in Aztec. So looking great!

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Aug 28, 2018

Member

@SergioEstevao, awesome to hear that. By the way, are there any other missing bits to make Gutenberg fully compatible in Aztec? This one was the only one I was aware of.

Member

gziolo commented Aug 28, 2018

@SergioEstevao, awesome to hear that. By the way, are there any other missing bits to make Gutenberg fully compatible in Aztec? This one was the only one I was aware of.

@Soean

This comment has been minimized.

Show comment
Hide comment
@Soean

Soean Aug 28, 2018

Member

@gziolo Thanks for your review. This is a better much better solution, I updated this PR.

Member

Soean commented Aug 28, 2018

@gziolo Thanks for your review. This is a better much better solution, I updated this PR.

@gziolo

gziolo approved these changes Aug 29, 2018 edited

This works great, thanks for adding the fix for the ref.

Would it be possible to improve the way poster is displayed? This is how it looks for my test video + image:

screen shot 2018-08-29 at 09 58 43

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Aug 29, 2018

Member

I added fix for the poster issue I shared. Kudos to @jasmussen for the solution. It still needs to be tested in IE11. I tested with the latest version of Chrome, FF and Safari.

Member

gziolo commented Aug 29, 2018

I added fix for the poster issue I shared. Kudos to @jasmussen for the solution. It still needs to be tested in IE11. I tested with the latest version of Chrome, FF and Safari.

@youknowriad youknowriad merged commit 208c0fa into master Aug 30, 2018

2 checks passed

codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the add/video-poster branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment