New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left margin of Archives block #9347

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@Rahmon
Contributor

Rahmon commented Aug 25, 2018

Description

Closes #9281

How has this been tested?

This has been tested with "npm test" and manually on Chrome

Screenshots

archives

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@@ -0,0 +1,3 @@
.gutenberg ul.wp-block-archives {

This comment has been minimized.

@ZebulanStanphill

ZebulanStanphill Aug 25, 2018

Contributor

Is there a specific reason why it is .gutenberg ul.wp-block-archives and not just .gutenberg .wp-block-archives?

@ZebulanStanphill

ZebulanStanphill Aug 25, 2018

Contributor

Is there a specific reason why it is .gutenberg ul.wp-block-archives and not just .gutenberg .wp-block-archives?

This comment has been minimized.

@Rahmon

Rahmon Aug 27, 2018

Contributor

Yes, there is. The Archives block can be displayed as dropdown and the class '.wp-block-archives' is used for div element.

@Rahmon

Rahmon Aug 27, 2018

Contributor

Yes, there is. The Archives block can be displayed as dropdown and the class '.wp-block-archives' is used for div element.

@youknowriad

LGTM 👍 Thanks for the fix

@youknowriad youknowriad merged commit d2074ef into WordPress:master Aug 27, 2018

2 checks passed

codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad added this to the 3.7 milestone Aug 27, 2018

@Rahmon Rahmon deleted the Rahmon:fix/9281 branch Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment