New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Columns block: change title/description to include deprecation notice. #9358

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
4 participants
@ZebulanStanphill
Contributor

ZebulanStanphill commented Aug 26, 2018

Description

This is a minor change which makes it more obvious for the average user to see that the Text Columns block is deprecated. Previously, warnings were only shown in the JavaScript console. This PR adds (deprecated) to the block title and changes the description to recommend usage of the Columns block instead. This should make it more obvious that the block is deprecated.

Additional notes

I wanted to also add the ability to transform a Text Columns block into a Columns block, but that is a much trickier task, so I am not doing it in this PR. If anyone with more experience wants to do that, then please do. I have created a separate PR for that: #9364. I think providing one-way transforms from deprecated blocks to their recommended replacements/closest-equivalents is a good idea for smooth transitions.

Ideally, you would want to automatically transform deprecated blocks into the recommended replacements, but the deprecated blocks API does not currently support migrating from/to a completely different block.

Related issues and PRs

@ajitbohra

LGTM 👍

@ZebulanStanphill ZebulanStanphill referenced this pull request Aug 26, 2018

Merged

Add Text Columns → Columns transform #9364

4 of 4 tasks complete
@ZebulanStanphill

This comment has been minimized.

Show comment
Hide comment
@ZebulanStanphill

ZebulanStanphill Aug 26, 2018

Contributor

I just created a PR for adding the Text Columns → Columns transform: #9364.

Contributor

ZebulanStanphill commented Aug 26, 2018

I just created a PR for adding the Text Columns → Columns transform: #9364.

@youknowriad youknowriad merged commit 42b0666 into WordPress:master Aug 27, 2018

2 checks passed

codecov/project 50.58% remains the same compared to 69ee079
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ZebulanStanphill ZebulanStanphill deleted the ZebulanStanphill:update/make-text-columns-deprecation-more-obvious branch Aug 27, 2018

@ZebulanStanphill

This comment has been minimized.

Show comment
Hide comment
@ZebulanStanphill

ZebulanStanphill Aug 27, 2018

Contributor

@youknowriad This needs to be added to the 3.7 milestone.

Contributor

ZebulanStanphill commented Aug 27, 2018

@youknowriad This needs to be added to the 3.7 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment