Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Components: Improve empty elements filters in Slot implementation #9371
This PR adds
How has this been tested?
Types of changes
referenced this pull request
Aug 27, 2018
Looks like a nice improvement. The only edge-case I can think of is
isEmptyElement( new String( '' ) ), which I think would return false. It'd be pretty easy to fix that using the same approach used with arrays.
Would also be great to add jsdocs for isEmptyElement
Correct, I updated the way we validate strings to accommodate that. I skipped a similar check for
Sep 5, 2018
I left my own comment about it #9371 (comment) where I assumed we don't want to expose it in
In that case I'd rather just flag it as experimental.
My main issue is that, as far as anything in