New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handbook documentation #9379

Merged
merged 9 commits into from Aug 30, 2018

Conversation

Projects
None yet
2 participants
@ajitbohra
Member

ajitbohra commented Aug 27, 2018

Some minor updates & improvements

@tofumatt

Some good changes and fixes in here! Thanks!

I think a few things need minor tweaks and I have a few questions, but I think after they're fixed we can get this merged. 👍

Show outdated Hide outdated docs/blocks/creating-dynamic-blocks.md
Show outdated Hide outdated docs/block-api/deprecated-blocks.md
Show outdated Hide outdated docs/block-api.md
Show outdated Hide outdated docs/block-api.md
Show outdated Hide outdated docs/block-api.md
@@ -52,22 +52,34 @@ description: 'Block showing a Book card.'
#### Category
* **Type:** `String [ common | formatting | layout | widgets | embed ]`

This comment has been minimized.

@tofumatt

tofumatt Aug 28, 2018

Member

Why remove the accepted values here?

@tofumatt

tofumatt Aug 28, 2018

Member

Why remove the accepted values here?

This comment has been minimized.

@ajitbohra

ajitbohra Aug 28, 2018

Member

Doesn't look good while reading 🙈 also felt repetitive as we are listing it.

Still, in 2 minds let me know what you suggest :)

@ajitbohra

ajitbohra Aug 28, 2018

Member

Doesn't look good while reading 🙈 also felt repetitive as we are listing it.

Still, in 2 minds let me know what you suggest :)

This comment has been minimized.

@tofumatt

tofumatt Aug 28, 2018

Member

Do we do it elsewhere? Normally I'd go with prettiness but this is an API doc so including those values might be good...

@tofumatt

tofumatt Aug 28, 2018

Member

Do we do it elsewhere? Normally I'd go with prettiness but this is an API doc so including those values might be good...

This comment has been minimized.

@ajitbohra

ajitbohra Aug 28, 2018

Member

Have added back values for now, just saw icon property accepts string or svg which we have mentioned as text.

I guess will give another round of reading to docs to find inconsistencies will do that in separate PR if any.

@ajitbohra

ajitbohra Aug 28, 2018

Member

Have added back values for now, just saw icon property accepts string or svg which we have mentioned as text.

I guess will give another round of reading to docs to find inconsistencies will do that in separate PR if any.

@@ -396,14 +408,16 @@ align: true,
align: [ 'left', 'right', 'full' ],
```
- `alignWide` (default `true`): Gutenberg allows to enable [wide alignment](../docs/extensibility/theme-support.md#wide-alignment) for your theme. To disable this behavior for a single block, set this flag to `false`.
- `alignWide` (default `true`): This property allows to enable [wide alignment](../docs/extensibility/theme-support.md#wide-alignment) for your theme. To disable this behavior for a single block, set this flag to `false`.

This comment has been minimized.

@tofumatt

tofumatt Aug 28, 2018

Member

Nice.

@tofumatt
Show outdated Hide outdated docs/block-api.md
Show outdated Hide outdated docs/block-api.md

ajitbohra and others added some commits Aug 28, 2018

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Aug 28, 2018

Member

I've noticed you making changes, thanks! Just let me know when it's ready for another review and I'll have a look! 😄

Member

tofumatt commented Aug 28, 2018

I've noticed you making changes, thanks! Just let me know when it's ready for another review and I'll have a look! 😄

@ajitbohra

This comment has been minimized.

Show comment
Hide comment
@ajitbohra

ajitbohra Aug 28, 2018

Member

@tofumatt done with changes for now :)

Member

ajitbohra commented Aug 28, 2018

@tofumatt done with changes for now :)

@tofumatt tofumatt self-requested a review Aug 28, 2018

ajitbohra and others added some commits Aug 29, 2018

@tofumatt

Thanks a bunch for all your work on these! 👍

Show outdated Hide outdated docs/block-api.md

@tofumatt tofumatt merged commit 566ed6d into master Aug 30, 2018

2 checks passed

codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tofumatt tofumatt deleted the update/docs branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment