New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Update package-lock.json to expected #9412

Merged
merged 2 commits into from Aug 29, 2018

Conversation

Projects
None yet
4 participants
@aduth
Member

aduth commented Aug 28, 2018

Fixes #9407
Issues introduced in #9321, #8911

This pull request seeks to resolve divergences in installed packages which result in local change or failed npm install.

Unsure if there's an easier process, but I undertook the following (very forcefully destructive steps) to remedy:

rm -rf node_modules
git clean -fdx
npm cache clean --force
npm install --no-save npm-package-json-lint@3.3.1
npm install

Testing instructions:

Verify there are no local changes after running npm install with a fresh clone with fresh npm cache.

cc @skorasaurus

@aduth aduth requested review from gziolo and ntwb Aug 28, 2018

@skorasaurus

This comment has been minimized.

Show comment
Hide comment
@skorasaurus

skorasaurus Aug 28, 2018

Contributor

I ran:

git checkout --track upstream/fix/package-lock-json-sha
npm install

that worked as expected!

but there was a diff as a result - https://gist.github.com/skorasaurus/22d92da910c42c6137caf1baa27b45b0

Contributor

skorasaurus commented Aug 28, 2018

I ran:

git checkout --track upstream/fix/package-lock-json-sha
npm install

that worked as expected!

but there was a diff as a result - https://gist.github.com/skorasaurus/22d92da910c42c6137caf1baa27b45b0

Show outdated Hide outdated package-lock.json
@ntwb

ntwb approved these changes Aug 29, 2018

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Aug 29, 2018

Member

Let's merge to resolve issues people experience in their local environments.

Member

gziolo commented Aug 29, 2018

Let's merge to resolve issues people experience in their local environments.

@gziolo gziolo merged commit a731af5 into master Aug 29, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@gziolo gziolo deleted the fix/package-lock-json-sha branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment