New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raAvoid changing the public API of the warning component to avoid Backwards compatibility breakage #9435

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Aug 29, 2018

closes #9431

This fixes a regression introduced in #7741 where we inadvertantly broke backwards compatibility (and other usage) of the Warning component.

I'm restoring the old name of the actions prop to fix the issue.

Testing instructions

Repeat steps from #9431
The warning should show up properly.

@youknowriad youknowriad requested review from johngodley and aduth Aug 29, 2018

@youknowriad youknowriad self-assigned this Aug 29, 2018

@johngodley

Verified all the places this is used. Thanks

@aduth

aduth approved these changes Aug 29, 2018

Thanks 👍 I also think this is more sensible anyways, since secondaryActions is probably the rare case of usage.

@youknowriad youknowriad changed the title from Avoid changing the public API of the warning component to avoid Backwards compatibility breakage to raAvoid changing the public API of the warning component to avoid Backwards compatibility breakage Aug 29, 2018

@youknowriad youknowriad merged commit 5a630c2 into master Aug 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/warning branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment