New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates: Always parse blocks from content #9448

Merged
merged 1 commit into from Aug 30, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Aug 29, 2018

Fixes #9433

This pull request seeks to resolve an issue where no demo content is shown on the demo screen. It does without sacrificing the original intent of #9288, which had been the cause for the regression described by #9433.

Post content is always parsed, regardless of whether a template is assigned or the post is new or being edited. This allows the initial demo content to be parsed as blocks.

If a template exists and the post is new, only then is the template applied by synchronizing. In most cases, the initial content would have been empty and the blocks an empty array (as had existed in previous logic), but this also accounts for potential divergences between content of the new post and the template.

Testing instructions:

Repeat steps to reproduce from #9433, verifying demo content is shown.

Repeat testing instructions from #9288.

Ensure end-to-end tests pass:

npm run test-e2e

@aduth aduth added this to the 3.7 milestone Aug 29, 2018

@aduth aduth requested a review from youknowriad Aug 29, 2018

@youknowriad

Seems legit code-wise. Can't test at the moment though. Feel free to merge if you're confident otherwise I'll test tomorrow.

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Aug 30, 2018

Contributor

Tested and confirmed that it works great.

Contributor

youknowriad commented Aug 30, 2018

Tested and confirmed that it works great.

@youknowriad youknowriad merged commit bf2ce55 into master Aug 30, 2018

2 checks passed

codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +16.42% compared to 540778b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/9433-template-new-post branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment