New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to add_theme_support docs #9488

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
3 participants
@benlk
Contributor

benlk commented Aug 31, 2018

Description

Because there's no style differences between php and es5 docs, provide a link to the add_theme_support PHP function where people can read more about it.

How has this been tested?

I made sure that GitHub's Markdown parser could parse the markdown.

Types of changes

documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Link to add_theme_support docs
Because there's no style differences between php and es5 docs, provide a link to the add_theme_support PHP function where people can read more about it.
@benlk

This comment has been minimized.

Show comment
Hide comment
@benlk

benlk Aug 31, 2018

Contributor

I note that https://developer.wordpress.org/reference/functions/add_theme_support/ doesn't mention align-wide. Should it?

Contributor

benlk commented Aug 31, 2018

I note that https://developer.wordpress.org/reference/functions/add_theme_support/ doesn't mention align-wide. Should it?

@Soean

This comment has been minimized.

Show comment
Hide comment
@Soean

Soean Aug 31, 2018

Member

I note that https://developer.wordpress.org/reference/functions/add_theme_support/ doesn't mention align-wide. Should it?

When Gutenberg is merged into core and 5.0 is released, we should add it. For now it only works with the Gutenberg plugin, so we keep it just in the Gutenberg handbook.

Member

Soean commented Aug 31, 2018

I note that https://developer.wordpress.org/reference/functions/add_theme_support/ doesn't mention align-wide. Should it?

When Gutenberg is merged into core and 5.0 is released, we should add it. For now it only works with the Gutenberg plugin, so we keep it just in the Gutenberg handbook.

@Soean Soean added the Documentation label Aug 31, 2018

@ajitbohra ajitbohra requested a review from tofumatt Aug 31, 2018

@tofumatt

Sorry for my delay in reviewing this, but makes sense to me! 👍

@tofumatt tofumatt merged commit 0d34280 into WordPress:master Sep 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment