New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Block: Fix drag and drop to create blocks #9493

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Aug 31, 2018

closes #9484

This PRs fixed a regression in the video block. It was using editorMediaUpload which was deprecated in favor of mediaUpload

Testing instructions

  • Repeat testing instructions in #9484 you shouldn't notice any error.

@youknowriad youknowriad added this to the 3.7 milestone Aug 31, 2018

@youknowriad youknowriad self-assigned this Aug 31, 2018

@youknowriad youknowriad requested a review from WordPress/gutenberg-core Aug 31, 2018

@gziolo

gziolo approved these changes Aug 31, 2018

So it was broken since 3.6 went out ...

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Aug 31, 2018

Contributor

Might be good to try an e2e test here, but it's not easy to test file drag and drop

Contributor

youknowriad commented Aug 31, 2018

Might be good to try an e2e test here, but it's not easy to test file drag and drop

@youknowriad youknowriad merged commit a3cd589 into master Aug 31, 2018

2 checks passed

codecov/project 50.23% remains the same compared to 07eeecf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/video-drag-and-drop branch Aug 31, 2018

@audrasjb

This comment has been minimized.

Show comment
Hide comment
@audrasjb

audrasjb Aug 31, 2018

Contributor

Thanks for the fix, @youknowriad ! 🎉

Contributor

audrasjb commented Aug 31, 2018

Thanks for the fix, @youknowriad ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment