Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Columns: Disable inserter on column block; Don't show stacked icon on columns #9523
We can not use the inserter to inserter a column so the inserter should be disabled on this block.
How has this been tested?
I Verified column block does not appear on the inserter, and that the columns block icon appear normally without the stacked indication.
Presumably there's already some metric which determines whether an inserter should be shown. Can that not be used in this case rather than adding an explicit support?
In the columns, case inserter is not available because of locking being equal to all. But locking is a dynamic property specific to each InnerBlock instance. A block may even set locking prop randomly, and each instance may have a different locking. On the inserter the stacked icon refers to all the block instances, we can not rely on locking or any dynamic InnerBlocks property to decide if we should show the stacked icon in the inserter or not. We need to rely on a setting that affects all the instances like the supports, and given that we already have a supports setting for the inserter that seems our best option.