Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
UI: Add a fullscreen mode #9567
This is looking awesome — I really like how fullscreen feels.
While using this, I clicked the
I'm interested to hear what others think.
I agree it's not perfect, but the current behavior is very similar to the customizer which is already a familiar fullscreen page for WordPressers
Nice work, this is working better than I would've expected, actually. GIF:
The X for close is working well, and is used in other places as well. It's a bit curious, because it feels very right to palace the X on the left here. But in other places, we place it on the right. Is this an inconsistency we want to look at? If yes, I think I'd prefer using a plain "Close" button rather than moving the X to the right, simply because because "More" menus should always be rightmost as they are to indicate "overflow" of buttons to the left of it, in an LTR reading direction.
I suppose an exception could be made, but I'm not sure if it would look weird with the sidebar close button being stacked below. Though we could decide to hide the sidebar close button on the desktop breakpoint, since when it's a sidebar it's easily toggled using the cog.
The "back to where you were" isn't working quite as well as I thought it would. I think it might work better if it always took you to the same place — like the posts list.
If the "Add new post" button in the toolbar was the primary interface (or only) for creating new posts, "back to where you were" would probably work better.
Nice job, also from an a11y perspective (but please see the comment about the "Close" link):
jasmussen left a comment
Technically this seems to be working very solidly.
There seems to be wide agreement among the reviewers here that this has value and should be tested. I happen to agree with that.
It also adds value to laptops that have limited screen real estate, like 11 inch laptops, presumably tablets as well. As such, I think we should get this in and iterate.
Sep 5, 2018
Thank you for all who worked on getting this done, I needed it badly.
I have some feedback on exiting/closing the fullscreen mode.
TLDR: X at the top left gave the affordance that i can get Out of the Full Screen mode. It should either close the mode or be removed.
What did i do:
My expectation: It should’ve got me out of fullscreen mode.
Let me know how further i can help.