New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Verse lines consistently on the front end #9584

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
3 participants
@brandonpayton
Member

brandonpayton commented Sep 3, 2018

Description

Today, we prevent wrapping Verse block lines in the editor because we want to preserve the author's intent, but that intent is not respected consistently on the front end where certain themes wrap Verse lines. This PR simply adds a rule to prevent Verse lines from wrapping on the front end in addition to the editor.

Fixes #4138.

How has this been tested?

I loaded a Verse block with a long line in the following themes and verified it was not wrapped:

  • TwentyTwelve (previously did not wrap)
  • TwentyFifteen (previously wrapped Verse lines)
  • TwentySixteen (previously wrapped Verse lines)

@brandonpayton brandonpayton added the Blocks label Sep 3, 2018

@brandonpayton brandonpayton added this to the 3.8 milestone Sep 3, 2018

@brandonpayton brandonpayton self-assigned this Sep 3, 2018

@brandonpayton brandonpayton requested a review from talldan Sep 3, 2018

@talldan

talldan approved these changes Sep 5, 2018

Had a read through the issue, this seems like a good compromise! 👍

pre.wp-block-verse {
white-space: nowrap;
overflow: auto;
}

This comment has been minimized.

@youknowriad

youknowriad Sep 5, 2018

Contributor

Should we remove the corresponding styles from editor.scss?

@youknowriad

youknowriad Sep 5, 2018

Contributor

Should we remove the corresponding styles from editor.scss?

This comment has been minimized.

@brandonpayton

brandonpayton Sep 6, 2018

Member

I'd wondered about that too and was on the fence. It nice to see all relevant properties in a single file. Some other blocks have property duplication between editor.scss and style.scss, so I just went with duplicating for now.

Thanks for merging, @youknowriad.

@brandonpayton

brandonpayton Sep 6, 2018

Member

I'd wondered about that too and was on the fence. It nice to see all relevant properties in a single file. Some other blocks have property duplication between editor.scss and style.scss, so I just went with duplicating for now.

Thanks for merging, @youknowriad.

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Sep 5, 2018

Contributor

Got a confirmation that this is fine design wise

Contributor

youknowriad commented Sep 5, 2018

Got a confirmation that this is fine design wise

@youknowriad youknowriad merged commit 104217d into master Sep 5, 2018

2 checks passed

codecov/project 50.36% remains the same compared to 4528ee3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/verse-nowrap-consistency branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment