New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hasSelectedInnerBlock does not accounts for multi selected innerBlocks #9592

Merged
merged 2 commits into from Sep 5, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Sep 3, 2018

If a block contained multi-selected children the selector hasSelectedInnerBlock returned false anyway. This caused a bug in Spotlight mode. If we had multiple blocks selected inside a column they still appeared with the grey mark as if they were not focused.

How has this been tested?

I checked that on Spotlight mode multi-selected blocks inside columns appear focused.

Screenshots

Before:
image

After:
image

Fix: hasSelectedInnerBlock does not accounts for multi selected inner…
… blocks;

If a block contained multi selected children the selector hasSelectedInnerBlock returned false anyway. This caused a bug in Spotlight mode. If we had multiple blocks selected inside a column they still appeared with grey mark is if they were not focused.

@jorgefilipecosta jorgefilipecosta requested a review from youknowriad Sep 3, 2018

@jorgefilipecosta jorgefilipecosta added this to the 3.8 milestone Sep 4, 2018

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Sep 5, 2018

Contributor

I think this creates a bug on "normal" mode (uncheck everything). This multi-selection triggers a border around the parent block. Noting that this bug is also present in master (without multiselection)

Contributor

youknowriad commented Sep 5, 2018

I think this creates a bug on "normal" mode (uncheck everything). This multi-selection triggers a border around the parent block. Noting that this bug is also present in master (without multiselection)

@youknowriad

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit 8704065 into master Sep 5, 2018

2 checks passed

codecov/project 50.85% (+0.48%) compared to cf74b67
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/focus-mode-nested-multiselect-bug branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment