New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Include Caption Styles in Video Block Caption #9609

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@nfmohit-wpmudev
Contributor

nfmohit-wpmudev commented Sep 4, 2018

Description

This PR closes #9581 which reports the unavailability of front-end styles for the video block's caption.

How has this been tested?

This PR has been tested by going through the following steps:

  1. Started a new post using the Gutenberg editor.
  2. Added the "Video" block.
  3. Added a video and a caption below it.
  4. Made sure the <figcaption> element for the video caption in the front-end is styled, even if the theme is not doing so.

This was tested in WordPress 4.9.8, Gutenberg 3.7.0 and it doesn't seem to be affecting any other parts.

Screenshots

pull-9581

Types of changes

This PR just includes the caption-style() mixin in the .wp-block-video figcaption element into the style.scss file for the video block which is getting rendered in the front-end.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@kjellr

kjellr approved these changes Sep 7, 2018

Looks good to me. Identical to the implementation for wp-block-image. 👍

@kjellr

This comment has been minimized.

Show comment
Hide comment
@kjellr

kjellr Sep 7, 2018

Contributor

Screenshots

Twenty Seventeen:
localhost_8888__p 51

Twenty Sixteen:
localhost_8888__p 51 1

(Some themes — like Twenty Sixteen — add margin below embeds, which adds the extra space you see there. But that's a good thing to tackle separately).

Nice work, @nfmohit-wpmudev!

Contributor

kjellr commented Sep 7, 2018

Screenshots

Twenty Seventeen:
localhost_8888__p 51

Twenty Sixteen:
localhost_8888__p 51 1

(Some themes — like Twenty Sixteen — add margin below embeds, which adds the extra space you see there. But that's a good thing to tackle separately).

Nice work, @nfmohit-wpmudev!

@kjellr kjellr added this to the 3.9 milestone Sep 7, 2018

@kjellr kjellr merged commit 0b0342c into WordPress:master Sep 7, 2018

2 checks passed

codecov/project 50.37% remains the same compared to ef25165
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nfmohit-wpmudev

This comment has been minimized.

Show comment
Hide comment
@nfmohit-wpmudev

nfmohit-wpmudev Sep 7, 2018

Contributor

Thank you for the review and merge @kjellr ❤️

Contributor

nfmohit-wpmudev commented Sep 7, 2018

Thank you for the review and merge @kjellr ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment