New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Gutenberg repository is clean after install #9650

Merged
merged 2 commits into from Sep 6, 2018

Conversation

Projects
None yet
3 participants
@gziolo
Member

gziolo commented Sep 6, 2018

Description

This PR fixes two things at once to ensure that fresh clone of Gutenberg repository is clean:

  • updates package-lock.json to prevent having it changed after npm i gets executed
  • regenerates docs for the handbook

Aside: Those are 2 very common issues, we should improve our tooling to be more strict when doing pre-commit hook and error when docs get updated. Not sure how to prevent issues with the lock file though.

@gziolo gziolo added the Code Quality label Sep 6, 2018

@gziolo gziolo added this to the 3.8 milestone Sep 6, 2018

@gziolo gziolo self-assigned this Sep 6, 2018

@gziolo gziolo requested review from youknowriad, pento, ntwb and WordPress/gutenberg-core Sep 6, 2018

@gziolo gziolo changed the title from Update/clean master to Ensure Gutenberg repository is clean after install Sep 6, 2018

@youknowriad

LGTM 👍

@youknowriad youknowriad merged commit 33ca4a3 into master Sep 6, 2018

2 checks passed

codecov/project 49.18% remains the same compared to 694a19b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/clean-master branch Sep 6, 2018

@@ -509,6 +503,12 @@
"markdown_source": "https://raw.githubusercontent.com/WordPress/gutenberg/master/packages/components.md",
"parent": null
},
{
"title": "AccessibleSvg",

This comment has been minimized.

@aduth

aduth Sep 6, 2018

Member

To clarify, this is auto-generated title? As code is concerned, this would be incorrect capitalization (vs. AccessibleSVG, which as best I can tell is correctly used elsewhere).

@aduth

aduth Sep 6, 2018

Member

To clarify, this is auto-generated title? As code is concerned, this would be incorrect capitalization (vs. AccessibleSVG, which as best I can tell is correctly used elsewhere).

This comment has been minimized.

@gziolo

gziolo Sep 7, 2018

Member

https://github.com/WordPress/gutenberg/blob/master/docs/tool/manifest.js#L57 - yes it is machine-generated. We could try to read it from the title of README.md as a first thing before using what we have at the moment.

@gziolo

gziolo Sep 7, 2018

Member

https://github.com/WordPress/gutenberg/blob/master/docs/tool/manifest.js#L57 - yes it is machine-generated. We could try to read it from the title of README.md as a first thing before using what we have at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment