New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show lint errors when there are lint problems #9661

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@notnownikki
Member

notnownikki commented Sep 6, 2018

A summary saying there were lint errors isn't too helpful
when you want to fix the lint errors, so this changes
the output so that the lint failures are shown.

How has this been tested?

Put a lint error in a php file, run run-script lint and it should tell you where the error is.

Show lint errors when there are lint problems
A summary saying there were lint errors isn't too helpful
when you want to fix the lint errors, so this changes
the output so that the lint failures are shown.

@notnownikki notnownikki requested a review from pento Sep 6, 2018

@notnownikki notnownikki added this to the 3.9 milestone Sep 6, 2018

@pento

pento approved these changes Sep 13, 2018

👻

@pento pento merged commit 75991a5 into master Sep 13, 2018

2 checks passed

codecov/project 49.18% remains the same compared to 84ea899
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pento pento deleted the update/show-lint-errors branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment