New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText Native: Adds onEnter callback and function placeholder. #9671

Merged
merged 8 commits into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@diegoreymendez
Contributor

diegoreymendez commented Sep 6, 2018

Description

This PR adds an onEnter callback property to the native implementation of RichText.

How has this been tested?

Tested in gutenberg-mobile. There's no logic yet but I tested the callback is being called properly.

Types of changes

Adds an onEnter callback property to the native implementation of RichText.
Adds a placeholder method and binds it to the callback.
Adds a console log that's printed whenever the callback is executed.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

SergioEstevao and others added some commits Aug 24, 2018

- Force update the RichText component when a toolbar button is pressed
- Fix an issue where eventCount was not correctly propogated to AztecText resulting in a re-rendering of the component from scratch
@SergioEstevao

This comment has been minimized.

Show comment
Hide comment
@SergioEstevao

SergioEstevao Sep 6, 2018

Contributor

@diegoreymendez don't you need a branch/PR on gutenberg-mobile that refers to this and to the updated version of react-aztec repo?

Contributor

SergioEstevao commented Sep 6, 2018

@diegoreymendez don't you need a branch/PR on gutenberg-mobile that refers to this and to the updated version of react-aztec repo?

@diegoreymendez

This comment has been minimized.

Show comment
Hide comment
@diegoreymendez
Contributor

diegoreymendez commented Sep 6, 2018

@SergioEstevao - You're right. The PR is here: wordpress-mobile/gutenberg-mobile#136

@SergioEstevao

Just need to update to the latest API for the onEnter event.

Merge branch 'try/add-onEnter-callback-to-rich-text' of github.com:Wo…
…rdPress/gutenberg into try/add-onEnter-callback-to-rich-text
@diegoreymendez

This comment has been minimized.

Show comment
Hide comment
@diegoreymendez

diegoreymendez Sep 10, 2018

Contributor

@SergioEstevao - My bad... I had made the changes in the submodule but failed to push them properly. It's not updated.

Contributor

diegoreymendez commented Sep 10, 2018

@SergioEstevao - My bad... I had made the changes in the submodule but failed to push them properly. It's not updated.

@diegoreymendez

This comment has been minimized.

Show comment
Hide comment
@diegoreymendez

diegoreymendez Sep 13, 2018

Contributor

@SergioEstevao - This is ready for another look.

Contributor

diegoreymendez commented Sep 13, 2018

@SergioEstevao - This is ready for another look.

@SergioEstevao

Good work.

@daniloercoli daniloercoli merged commit 02d530a into master Sep 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daniloercoli daniloercoli deleted the try/add-onEnter-callback-to-rich-text branch Sep 13, 2018

@mtias mtias added this to the 3.9 milestone Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment