Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add dark editor style support #9683
This fixes #6451.
This PR enables a new command to themers. They can now add
What this does is add a body class to the editor,
To test, add a dark editor style, then enable support. For example, add this to your theme functions.php:
In "style-editor.css", put the following:
Now test and see that the UI is usable.
referenced this pull request
Sep 7, 2018
Thanks for the reviews!
Important to note for passers by: this is not a dark theme for Gutenberg.
This PR enables UI to work on dark editor style backgrounds.
The difference here is that you can imagine any color background as defined by the WordPress theme in question. In this case, I picked a very dark gray at random.
"Dark canvas" sounds cool.
At any rate, sounds like this is doing the right thing, but it's sort of weird that dark canvas doesn't at least have some saner defaults. I get no styling has been done to the sidebar, but if that's how it looks unstyled we could do better.
But that can totally be a later issue. This isn't a super-high priority
That works for me.
Generally I'm cool with the idea that theme content doesn't affect UI or with the idea that it can, but since this PR seems to allow the latter to a certain degree I say we just go for it and allow further UI adjustments.
As mentioned though: can happen later, feel free to ship