New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Embed block: remove unnecessary class from a placeholder #9688

merged 1 commit into from Sep 7, 2018


None yet
3 participants

jorgefilipecosta commented Sep 7, 2018

Caused in #9466.


The class wp-block-embed was repeated on the placeholder and the figure. This PR just removes the class from the placeholder.

How has this been tested?

I verified there were no design changes when adding an embed with a preview not available e.g: #9466.

@jorgefilipecosta jorgefilipecosta requested review from notnownikki and mtias Sep 7, 2018

@jorgefilipecosta jorgefilipecosta merged commit a359efc into master Sep 7, 2018

2 checks passed

codecov/project 49.18% remains the same compared to 9a6bf39
continuous-integration/travis-ci/pr The Travis CI build passed

@jorgefilipecosta jorgefilipecosta deleted the fix/duplicate-class-name-embed-placeholder branch Sep 7, 2018

@mtias mtias added this to the 3.9 milestone Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment