New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qs dependency typo #9692

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Sep 7, 2018

Related #8300 (comment)

@youknowriad youknowriad self-assigned this Sep 7, 2018

@youknowriad youknowriad requested a review from aduth Sep 7, 2018

@@ -20576,7 +20576,7 @@
},
"chalk": {
"version": "1.1.3",
"resolved": "https://registry.npmjs.org/chalk/-/chalk-1.1.3.tgz",
"resolved": "http://registry.npmjs.org/chalk/-/chalk-1.1.3.tgz",

This comment has been minimized.

@youknowriad

youknowriad Sep 7, 2018

Contributor

Not sure why the npm install changed this too

@youknowriad

youknowriad Sep 7, 2018

Contributor

Not sure why the npm install changed this too

@aduth

Should we note this in CHANGELOG.md for a patch release of @wordpress/url ?

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Sep 7, 2018

Contributor

@aduth I don't have the changelog habit yet :P

Contributor

youknowriad commented Sep 7, 2018

@aduth I don't have the changelog habit yet :P

@aduth

aduth approved these changes Sep 7, 2018

@youknowriad youknowriad merged commit c1cdd95 into master Sep 7, 2018

2 checks passed

codecov/project 49.07% remains the same compared to 8d46362
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/qs-dependency branch Sep 7, 2018

@mtias mtias added this to the 3.9 milestone Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment