New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNMobile - Do not propagate eventCount to components #9733

Merged
merged 9 commits into from Sep 10, 2018

Conversation

Projects
None yet
3 participants
@daniloercoli
Contributor

daniloercoli commented Sep 10, 2018

Description

In this PR I've modified the native version of RichText that now doesn't propagate the eventCount property to components since it was an implementation details, but instead RichText keeps it locally, and use it to check if re-render is needed.

A new prop forceUpdate can now be used by components (Para and heading for axample) to force an update when required. Note that it's currently unused.

Note: This PR replaces #9580

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

SergioEstevao and others added some commits Aug 24, 2018

Hide eventCount to components that use RichText. Introduce `forceUpèd…
…ate` to force an update over ReactNativeAztec
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/Do-not-expose-eventCount-to-components

# Conflicts:
#	packages/block-library/src/heading/edit.native.js

@daniloercoli daniloercoli reopened this Sep 10, 2018

@daniloercoli daniloercoli referenced this pull request Sep 10, 2018

Closed

RNMobile - Do not propagate eventCount to components #9580

0 of 4 tasks complete
@SergioEstevao

Looking good!

@daniloercoli daniloercoli merged commit e632c7d into master Sep 10, 2018

2 checks passed

codecov/project 49.02% (-0.01%) compared to 410f78a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daniloercoli daniloercoli deleted the rnmobile/Do-not-expose-eventCount-to-components branch Sep 10, 2018

@mtias mtias added this to the 3.9 milestone Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment