Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adjust margin rules for nested blocks. #9735
This PR one one hand fixes #9730, and on the other hand simplifies some of the column wrangling code to be simpler.
It does visualy regress it slightly: previously we'd use negative margins to make it so text inside columns looked to be spaced the same as text before and after the columns.
However this greatly complexified the CSS, which caused #9730 in the first place. The thing is — the columns block itself has a margin. This margin collapses correctly to adjacent blocks. But given it also has children, those margins don't also collapse. Possibly we could make this happen, I'm unsure, flex containers are supposed to prevent margin collapsing by creating their own contexts, but it seems like the negative margins added complexity where it wasn't helpful.
The difference is subtle. But look how the margin between text inside and outside the columns block used to be the same. This is no longer the case, but perhaps worth it as a simplification fix, and then possibly something to revisit separately.