New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notice styling regression #9736

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Sep 10, 2018

Just a tiny PR aligning notices properly.

closes #9725 and closes #9422

I suspect this being a regression of #8856

@youknowriad youknowriad added this to the 3.9 milestone Sep 10, 2018

@youknowriad youknowriad self-assigned this Sep 10, 2018

@youknowriad youknowriad requested review from karmatosed and jasmussen Sep 10, 2018

@jasmussen

Confirmed, fixes this! Scratching it from my own list, thanks Riad!

screen shot 2018-09-10 at 14 30 16

@youknowriad youknowriad merged commit 99beb15 into master Sep 10, 2018

2 checks passed

codecov/project 49.03% remains the same compared to 410f78a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/small-notice-regression branch Sep 10, 2018

@afercia

This comment has been minimized.

Show comment
Hide comment
@afercia

afercia Sep 10, 2018

Contributor

@youknowriad shouldn't the notices always be wrapped in a paragraph as #9426 was proposing for #9422 ?

Contributor

afercia commented Sep 10, 2018

@youknowriad shouldn't the notices always be wrapped in a paragraph as #9426 was proposing for #9422 ?

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Sep 10, 2018

Contributor

@afercia The issue is that in some cases, the paragraph styling is changed (like in the sidebar) breaking the notices, An alternative fix would have been to override the notices styles as well in the sidebar, I preferred the "smaller" change.

Contributor

youknowriad commented Sep 10, 2018

@afercia The issue is that in some cases, the paragraph styling is changed (like in the sidebar) breaking the notices, An alternative fix would have been to override the notices styles as well in the sidebar, I preferred the "smaller" change.

@afercia

This comment has been minimized.

Show comment
Hide comment
@afercia

afercia Sep 10, 2018

Contributor

OK thanks, going to close the other PR then.

Contributor

afercia commented Sep 10, 2018

OK thanks, going to close the other PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment