New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save level to heading block attributes or parse will fail. #9741

Merged
merged 2 commits into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@SergioEstevao
Contributor

SergioEstevao commented Sep 10, 2018

Description

When parsing heading block attributes if the level is not 2, it needs to be save to block attributes in order for the parser to work correctly.

How has this been tested?

Edit a Heading block by setting to H4
Switch to HTML mode and back to Visual
Check that app doesn't crash.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@daniloercoli

This comment has been minimized.

Show comment
Hide comment
@daniloercoli

daniloercoli Sep 10, 2018

Contributor

Looks good!

Contributor

daniloercoli commented Sep 10, 2018

Looks good!

@SergioEstevao SergioEstevao merged commit 960bb6e into master Sep 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SergioEstevao SergioEstevao deleted the rnmobile/fix_on_heading_parse branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment