New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust unified block toolbar padding at medium breakpoints. #9742

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@kjellr
Contributor

kjellr commented Sep 10, 2018

Fixes a visual bug where the block controls in Unified Toolbar are larger than their container bar on screens that are between 781px and 960px wide.

Fixes #9657.

To Test:

  1. Activate Unified Toolbar mode from the ellipsis menu.
  2. Scale your screen down so it's in between 781px and 960px wide.
  3. Select a block, and observe the way the block toolbar looks at the top of the screen.

Screenshots

Before:
screen shot 2018-09-10 at 9 22 28 am

After:
screen shot 2018-09-10 at 9 20 36 am

Move unified block toolbar padding to large breakpoints.
Fixes a visual bug where the block controls in Unified Toolbar are larger than their container bar on screens that are between 781px and 960px wide.

Fixes #9657.

@kjellr kjellr added the [Type] Bug label Sep 10, 2018

@kjellr kjellr added this to the 3.9 milestone Sep 10, 2018

@kjellr kjellr requested review from youknowriad and jasmussen Sep 10, 2018

@jasmussen

Yep, works for me! Nice!

@kjellr kjellr changed the title from Move unified block toolbar padding to large breakpoints. to Adjust unified block toolbar padding at medium breakpoints. Sep 10, 2018

@kjellr kjellr merged commit 9e56083 into master Sep 10, 2018

2 checks passed

codecov/project 49.03% remains the same compared to 99beb15
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kjellr

This comment has been minimized.

Show comment
Hide comment
@kjellr

kjellr Sep 10, 2018

Contributor

Thanks! 🙌

Contributor

kjellr commented Sep 10, 2018

Thanks! 🙌

@kjellr kjellr deleted the fix/block-unified-toolbar-middle-breakpoints branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment