New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Convert back and forth from a cover image block #9743

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Sep 10, 2018

closes #6475

PR making it possible to convert cover images to images and vice versa.

Testing instructions

  • Try converting images to cover images (and convert back)
  • Notice most of the attributes are kept.

@youknowriad youknowriad self-assigned this Sep 10, 2018

@youknowriad youknowriad requested review from chrisvanpatten and WordPress/gutenberg-core Sep 10, 2018

@kjellr

kjellr approved these changes Sep 10, 2018

Works great on my end. Here's a GIF:

caption-cover-image

@chrisvanpatten

LGTM too! 🚢

@youknowriad youknowriad merged commit 8b1926d into master Sep 10, 2018

2 checks passed

codecov/project 49.02% (-0.01%) compared to 99beb15
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the add/image-cover-image-conversion branch Sep 10, 2018

@youknowriad youknowriad added this to the 3.9 milestone Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment