New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/9785 - Remove isButton prop #9786

Merged
merged 2 commits into from Sep 11, 2018

Conversation

Projects
None yet
3 participants
@amdrew
Contributor

amdrew commented Sep 11, 2018

Fixes #9785

Description

Removed the isButton prop

How has this been tested?

Removed prop, recompiled, opened color settings panel and there was no error.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@amdrew amdrew changed the title from Remove isButton prop to Issue/9785 - Remove isButton prop Sep 11, 2018

@Soean

This comment has been minimized.

Show comment
Hide comment
@Soean

Soean Sep 11, 2018

Member

@amdrew You also have to change the snapshots in the tests.

The prop was introduced in #8875

Member

Soean commented Sep 11, 2018

@amdrew You also have to change the snapshots in the tests.

The prop was introduced in #8875

@amdrew

This comment has been minimized.

Show comment
Hide comment
@amdrew

amdrew Sep 11, 2018

Contributor

@Soean Cool, wasn't sure if I should remove those, fixed 👍

Contributor

amdrew commented Sep 11, 2018

@Soean Cool, wasn't sure if I should remove those, fixed 👍

@Soean

Soean approved these changes Sep 11, 2018

The tests are fine now.

There is no isButton prop, see https://github.com/WordPress/gutenberg/blob/master/packages/components/src/button/index.js
The is-button class is applied, if you use isDefault. So I think we can merge it. @tofumatt do you agree?

@Soean Soean requested a review from tofumatt Sep 11, 2018

@Soean Soean added this to the 3.9 milestone Sep 11, 2018

@tofumatt

Makes sense to me. isButton is a weird prop for a button to have, happy to nix it 😄

@tofumatt tofumatt merged commit 406dc2c into WordPress:master Sep 11, 2018

2 checks passed

codecov/project 49.02% remains the same compared to 7e479a0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment